-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automation: better dependency management #690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand why anyone would want to implement functionality similar to something that is already available in dependabot and maintain it. I cannot review this PR.
My opinion should not discourage anyone from merging this PR. I was asked to review. It seemed impolite to ignore the request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description of the functionality looks good to me and the solution appears to be able to handle the dependency topics similar to what we had discussed as we want it - not updating dependencies automatically and being able to update unresolved dependency PRs. I'd also like to have issues updated instead of closing the outdated ones, so that we don't have a lot of those issues to search through. Do you think you can implement that as well?
7c0e259
to
040f93e
Compare
Done the change that @berndfinger requests, done some more test and update the description of the pr. Check it for the insight of the feature request! |
This prevents the issue creation when run after a merge into a different branch than the default one
I cant do the merge without at least 1 review :) do you want to be the one @berndfinger ? |
@Wabri Happy to be the one ;-) Have https://github.com/Wabri/community.sap_install/issues/101 and https://github.com/Wabri/community.sap_install/issues/104 been processed with this code? |
Yes, the only difference is that in my fork I've use the main as a base for the pr, but in the main repository (this one) all the pr and changes will be referred to the dev branch. After the merge of this pr, I'll run the action for the first time and check that everything went fine. Also the old issue: #692, #674, #683, and #691, will be removed to let the newly actions have a clean run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Better description to issues
Now the issue contains a better explanation:
Automatic update issue when a new package is out
If a new version of a packages comes out and there is already another issue that have a reference to the old latest package:
PR opening and update itself
automation/dependencies_update
if not already exists2 more variable to personalise the action
OPEN_PR
andOPEN_PR_BASE
to enable the automated creation of the pull request and the second is to set the base branch to where the pr must be merge to.Better logging
Example of 2 consecutive runs
First run
https://github.com/Wabri/community.sap_install/actions/runs/8572426995/job/23494940880#step:3:405
pip3 list --outdated
)automation/dependencies_update
where to put all the changesChanges to reproduce a use-case
Second run:
https://github.com/Wabri/community.sap_install/actions/runs/8572506782/job/23495216128#step:3:404
pip3 list --outdated
)automation/dependencies_update