Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Code-Generators #154

Closed
BugRoger opened this issue Jan 10, 2018 · 2 comments
Closed

Upgrade Code-Generators #154

BugRoger opened this issue Jan 10, 2018 · 2 comments

Comments

@BugRoger
Copy link
Contributor

BugRoger commented Jan 10, 2018

Upgrade the Go dependency to https://github.com/kubernetes/code-generator

This allows us to use the deepcopy generator, that will simplify the ugly copy-by-remote-call:

copy, err := cpm.Clients.Kubernikus.Kubernikus().Klusters(cpm.Kluster.Namespace).Get(cpm.Kluster.Name, metav1.GetOptions{})
if err != nil {
return err

To:

copy := kluster.DeepCopy()

It will also allow us to use an inbuilt script and get rid of the whole code-gen Makefile magic:

https://github.com/kubernetes/sample-controller/blob/258eead08702028194ade1c0a7f958c837d6f081/hack/update-codegen.sh#L28-L31

Open question: The code-generators need to be in sync with the api-machinery version. Does the api-machinery library need to be in sync with the cluster it's running on?

@databus23
Copy link
Member

You mean client-go dependency?

@databus23
Copy link
Member

databus23 commented Jan 10, 2018

ah no the generator dep, I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants