Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades to client-go v6.0.0 #163

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Upgrades to client-go v6.0.0 #163

merged 1 commit into from
Jan 12, 2018

Conversation

BugRoger
Copy link
Contributor

Fixes #154

@databus23
Copy link
Member

wooho! 100k LOC removed. I'm already liking this...

@BugRoger
Copy link
Contributor Author

Github actually nicely sorts (most) of my changes to the top, if anyone wants to take a look.

@databus23
Copy link
Member

With the new FilteredInformers we should be able to get rid of this: https://github.com/sapcc/kubernikus/blob/client_v6/pkg/controller/operator.go#L216 yes?

databus23
databus23 reviewed Jan 12, 2018
View reviewed changes
Copy link
Member

@databus23 databus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed it. Looks a'ight to me.

@BugRoger BugRoger merged commit ee49537 into master Jan 12, 2018
@BugRoger BugRoger deleted the client_v6 branch January 12, 2018 12:58
@databus23 databus23 mentioned this pull request Jan 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@databus23 databus23 databus23 left review comments

@SchwarzM SchwarzM SchwarzM approved these changes

Assignees
No one assigned
Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BugRoger @databus23 @SchwarzM