Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx ingress #104

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Nginx ingress #104

merged 1 commit into from
Nov 28, 2017

Conversation

auhlig
Copy link
Member

@auhlig auhlig commented Nov 17, 2017

we want the ingress custom backend is already deployed in the admin cluster in the kubernikus control plane.
official helm chart for nginx-ingress as base but with custom backend that also knows json. fixes #80.

Initially I wanted to use it as a dependency but override the image of the custom backend, but that doesn't seem to work.

@auhlig auhlig requested a review from databus23 as a code owner November 17, 2017 21:00
name: controller
image:
repository: gcr.io/google_containers/nginx-ingress-controller
tag: "0.9.0-beta.14"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we are not using latest (beta.17)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I'll test in staging first and update this PR afterwards

@auhlig auhlig force-pushed the nginx-ingress branch 3 times, most recently from c0557ac to e2c629d Compare November 23, 2017 05:31
@auhlig
Copy link
Member Author

auhlig commented Nov 23, 2017

Squashed, rebased and manually deployed to k-staging cluster. The custom backend currently only handles 404, 500

@auhlig
Copy link
Member Author

auhlig commented Nov 23, 2017

Wanted to test the new controller in staging first, but it's a mess since they changed all nginx-based annotations :-/ Should be easier to get it in here.

@auhlig auhlig merged commit dbe0bb3 into master Nov 28, 2017
@auhlig auhlig deleted the nginx-ingress branch November 28, 2017 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingress Default Backend doesn't know JSON
2 participants