Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Public-Key to GetMetadata Call #159

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Adds Public-Key to GetMetadata Call #159

merged 2 commits into from
Jan 11, 2018

Conversation

BugRoger
Copy link
Contributor

This PR adds the public-key to the getmetadata call. The intention is to use this as a convenience feature in the UI.

The key will be copied to a free-text field. Alernatively the user will be able to provide a whole different key by herself.

Fixes #156

@BugRoger BugRoger requested review from databus23 and edda January 10, 2018 16:30
@BugRoger
Copy link
Contributor Author

@edda new json will look like:

...,
  "keyPairs": [
    {
      "name": "id_rsa",
      "publicKey": "ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAvFapuevZeHFpFn438XMjvEQYd0wt7+tzUdAkMiSd007Tx1h79Xm9ZziDDUe4W6meinVOq93MAS/ER27hoVWGo2H/vn/Cz5M8xr2j5rQODnrF3RmfrJTbZAWaDN0JTq2lFjmCHhZJNhr+VQP1uw4z2ofMBP6MLybnLmm9ukzxFYZqCCyfEEUTCMA9SWywtTpGQp8VLM4INCxzBSCuyt3SO6PBvJSo4HoKg/sLvmRwpCVZth48PI0EUbJ72wp88Cw3bv8CLce2TOkLMwkE6NRN55w2aOyqP1G3vixHa6YcVaLlkQhJoJsBwE3rX5603y2KjOhMomqHfXxXn/3GKTWlsQ== [email protected]"
    }
  ],
...

@databus23
Copy link
Member

Lgtm but I‘n already working on this since before Christmas. I have something similar like this in an umpushed branch. We can use this and I adjust my code but I already assigned all related tickets to me as I already have 90% of th Code done.

databus23
databus23 approved these changes Jan 11, 2018
View reviewed changes
Copy link
Member

@databus23 databus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@databus23
Copy link
Member

databus23 commented Jan 11, 2018 •
edited
Loading

@edda Please review and merge at you earliest convenience. I will then continue my work on the remaining ssh key stuff based on this PR.

@BugRoger
Copy link
Contributor Author

BugRoger commented Jan 11, 2018 •
edited
Loading

@databus23 Lgtm but I‘n already working on this since before Christmas.

Oops, sorry. This PR literally took me 1 minute. I was looking into the API and whether the public-key actually falls out. I don't mind either way.

edda
edda approved these changes Jan 11, 2018
View reviewed changes
Copy link
Contributor

@edda edda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Will start to prepare the UI as discussed so we can roll this out when the rest is ready

@BugRoger BugRoger merged commit c06c3f3 into master Jan 11, 2018
@BugRoger BugRoger deleted the add_public_keys branch January 11, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edda edda edda approved these changes

@databus23 databus23 databus23 approved these changes

Assignees
No one assigned
Labels
apiserver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BugRoger @databus23 @edda