Surface nova errors message for bad request responses (400) #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gophercloud at the moment just returns a generic “bad request” error message when nova returns a status 400 response for a server create request. But the response actually contains a detailed error message as to why the payload wasn’t accepted. (e.g. given image/flavor/key not found etc.) There is a 1 year old upstream PR solving the same thing but unfortuantely its going nowhere: gophercloud/gophercloud#303
BugRoger
approved these changes
Jan 11, 2018
| } | ||
|
|
||
| func (ce createError) Error() string { | ||
| return "Failed to create server. This should not never be printed." |
There was a problem hiding this comment.
The deserialisation has to be defined for each error code. If quota errors result in a 400 bad request its already covered. If quota errors return something different we need to implement an additional interface for it.
There was a problem hiding this comment.
Ups. You got me. this doesn't make sense. one negation to much.
|
So it seems quota errors are returned as I opened an issue at gophercloud to get some feedback: gophercloud/gophercloud#713 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gophercloud at the moment just returns a generic “bad request” error message when nova returns a status 400 response for a server create request.
But the response actually contains a detailed error message as to why the payload wasn’t accepted. (e.g. given image/flavor/key not found etc.)
There is a 1 year old upstream PR solving the same thing but unfortuantely its going nowhere: gophercloud/gophercloud#303