Specify security group by name #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugRoger
approved these changes
Jan 12, 2018
| } | ||
| securityGroups := make([]map[string]interface{}, len(opts.SecurityGroups)) | ||
| for i, groupID := range opts.SecurityGroups { | ||
| securityGroups[i] = map[string]interface{}{"id": groupID} |
There was a problem hiding this comment.
Is this a "vendored" bugfix for Gophercloud?
There was a problem hiding this comment.
This was my contrived way overriding gophercloud default behaviour expecting security group names (which turns out to be the only correct way). I just removed my override to change that into an id field.
There was a problem hiding this comment.
So no, its not a bugfix. Its just crap I wrote that doesn't work that we now remove again.
|
@edda FYI: The spec field changes from |
Turns out specifying security groups by id doesn’t not work at all. We have to specify it by name, as the official documentation demands it.
|
@edda Good to merge? Will this break the UI? |
|
@databus23 Merge away. The UI is ready for the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out specifying security groups by id doesn’t not work at all.
We have to specify it by name, as the official documentation demands it.
Fixes #152 fixes #172