caches cors preflight request for 10 min #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense I would even set it to a higher value. 6 hours or more. Our CORS rules are static and are not going to change frequently. |
|
Yeah, I wanted to set it to 24 hours but apparently many browsers don't allow high values for this. Chrome e.g. seems to allow a maximum of 10 minutes. Something about possibililty of cache poisoning. So I figured I'll use a value that is hopefully respected by all browsers to get similar behaviour across browsers. But I don't mind using a longer time and see what happens... |
|
ok 10 minutes it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache the result of the preflight request for 10 minutes so the browser doesn't do a preflight request every time. This'll speed up the api calls since it won't do two requests every time.