Prevent deletion of kluster as long as nodepools are present #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugRoger
requested changes
Oct 27, 2017
| @@ -20,7 +21,18 @@ type terminateCluster struct { | |||
|
|
|||
| func (d *terminateCluster) Handle(params operations.TerminateClusterParams, principal *models.Principal) middleware.Responder { | |||
|
|
|||
| _, err := editCluster(d.Kubernikus.Kubernikus().Klusters(d.Namespace), principal, params.Name, func(kluster *v1.Kluster) { | |||
| k, err := d.Kubernikus.Kubernikus().Klusters(d.Namespace).Get(qualifiedName(params.Name, principal.Account), metav1.GetOptions{}) | |||
There was a problem hiding this comment.
Let's extract this kluster a variable, so we can reuse it later...
| return NewErrorResponse(&operations.TerminateClusterDefault{}, 409, "Cluster still has NodePools") | ||
| } | ||
|
|
||
| _, err = editCluster(d.Kubernikus.Kubernikus().Klusters(d.Namespace), principal, params.Name, func(kluster *v1.Kluster) { |
There was a problem hiding this comment.
Reuse kluster from above.
There was a problem hiding this comment.
Also remove the double error handling below...
BugRoger
approved these changes
Nov 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If nodes are still present during a terminate the routes will not be deleted from the neutron router.
As long as we do not implement a more sophisticated cleanup we should prevent klusters with
nodepools from terminating.