Expose service and cluster CIDR in the api #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to optionally specify the service and cluster cidr when creating a cluster. It can’t be changed afterwards.
|
no i am using the marshal method of the generated client |
SchwarzM
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to optionally specify the service and cluster cidr when creating a cluster.
It can’t be changed afterwards.
By default it will still be set to
198.18.128.0/17198.19.0.0/16We need this so we can re-create our parent clusters to avoid routing conflicts with the child clusters.
@SchwarzM Does
kubernikusctlneed changing to support creating a cluster with different CIDRs?