Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go-swagger 0.12.0 #91

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Update to go-swagger 0.12.0 #91

merged 1 commit into from
Nov 6, 2017

Conversation

databus23
Copy link
Member

  • lock dependencies of generatered code to the go-swagger version
  • Unify generated client and server under pkg/api

@databus23
Copy link
Member Author

databus23 commented Nov 3, 2017 •
edited
Loading

I realise this is tough to review. Not really required from my side. I just wanted to track the progress on the update in a PR.

@SchwarzM
Copy link
Contributor

SchwarzM commented Nov 3, 2017

merging a big part of the code and increase the codebase by 60k lines ?

@databus23
Copy link
Member Author

What can I say the increase in code comes from locking the dependencies to the actual versions used by go-swagger. Let me see if maybe there is more vendored then needed.

SchwarzM
SchwarzM approved these changes Nov 3, 2017
View reviewed changes
Copy link
Contributor

@SchwarzM SchwarzM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break printing clusters as the print method is currently tagged on to the generated model but i think it is an easy fix i will do once merged

@databus23
Copy link
Member Author

databus23 commented Nov 3, 2017 •
edited
Loading

I excluded golang.org/x/net golang.org/x/text and now we are down do adding 5000 LOC. Thats ok the changed deps just pull in more files.

@databus23 databus23 changed the title WIP: Update to go-swagger 0.12.0 Update to go-swagger 0.12.0 Nov 6, 2017
@databus23
Copy link
Member Author

rebased. Pretty sane now, just moving some files around and updating dependencies. @BugRoger please review. I don't want to rebase this again :)

BugRoger
BugRoger approved these changes Nov 6, 2017
View reviewed changes
Copy link
Contributor

@BugRoger BugRoger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BugRoger BugRoger merged commit 534e90f into master Nov 6, 2017
auhlig added a commit that referenced this pull request Nov 7, 2017
@auhlig
aftermath of #91
62f469a
@databus23 databus23 deleted the swagger-0.12.0 branch November 10, 2017 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchwarzM SchwarzM SchwarzM approved these changes

@BugRoger BugRoger BugRoger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@databus23 @SchwarzM @BugRoger