unify kluster specs #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UI is ready to be tested with this change. I made the necessary changes (not deployed yet) |
This commit unifies the kluster specs used by the apiserver and the CRD.
databus23
force-pushed
the
unify-spec
branch
2 times, most recently
from
c62825a to
8b32417
Compare
databus23
force-pushed
the
unify-spec
branch
from
8b32417 to
ccb78e1
Compare
* Remove unused Spec.Domain * Spec.ClusterDNS —> Spec.DNSAddress * Spec.ClusterDNSDomain —> spec.DNSDomain
|
@edda three more changes to the api (See last 3 bullets above). Can you confirm this won't break your stuff? I think you are not using those fields yet. |
BugRoger
approved these changes
Nov 10, 2017
|
By the powers of greyskull I'm merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit unifies the kluster specs used by the apiserver and the CRD.
This change contains some minor breaking api changes:
Kluster.Status.Kluster.State-->Kluster.Status.PhaseReadystate is nowRunningphaseKluster.Status.Kluster.Message-->Kluster.Status.MessageKluster.Spec.Version-->Kluster.Status.VersionKluster.Spec.DomainKluster.Spec.ClusterDNS-->Kluster.Spec.DNSAddressKluster.Soec.ClusterDNSDomain-->Kluster.Spec.DNSDomain