Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix pipeline_test that partially stopped working due to introduction of shap and confusion matrix. #30

Conversation

arima-tsukasa
Copy link
Contributor

@kimusaku
@AkiraUra

  • Scripts generated with generatedcode fail with shap.plots.beeswarm.(Scripts generated with generatedcode fail with shap.plots.beeswarm. sapientml#68)
    • beeswarm cannot plot a graph with multiple shap_values.
    • Deal with multi-class and LightGBM binary classification where multiple shap_values are computed as follows:
      • For multiclass, do not plot
      • For LightGBM, specify masker for Explainer.
  • Scripts generated with generatedcode fail with shap.Explainer. (Scripts generated with generatedcode fail with shap.Explainer. sapientml#67)
    • If you enter masker uniformly in the Explainer, an error occurs in the calculation of shap_values depending on the data.
    • Specify masker only if necessary.
  • There is a lack of action to undo converted values when using LabelEncoder.
    • Add processing immediately for predict, or on input to confusion matrix for predict_proba.

arima-tsukasa and others added 21 commits October 26, 2023 16:36
Signed-off-by: arima-tsukasa <[email protected]>
Signed-off-by: arima-tsukasa <[email protected]>
@arima-tsukasa
Copy link
Contributor Author

Fix to output predict_result.csv in the format specified by predict_option and metric.

  • Added None to predict_option of SapientMLConfig.
    • Specify predict method (default: predict(), probability: predict_proba(), None: Comply with metric requirements.)

@arima-tsukasa arima-tsukasa marked this pull request as ready for review November 24, 2023 02:05
@arima-tsukasa arima-tsukasa requested a review from a team as a code owner November 24, 2023 02:05
@arima-tsukasa arima-tsukasa requested review from kimusaku and AkiraUra and removed request for a team November 24, 2023 02:05
@kimusaku kimusaku enabled auto-merge (squash) November 27, 2023 12:42
Copy link
Contributor

@kimusaku kimusaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kimusaku kimusaku merged commit f0d33b1 into sapientml:main Nov 28, 2023
marscod pushed a commit to marscod/core that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants