Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compile for es2020 instead of es2021 #128

Merged
merged 7 commits into from
Jun 19, 2022

Conversation

vladfrangu
Copy link
Member

@vladfrangu vladfrangu commented Jun 17, 2022

Allows users of nodejs 14+ to use shapeshift

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #128 (ecfd35a) into main (a23d15f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          51       51           
  Lines        1494     1494           
  Branches      320      321    +1     
=======================================
  Hits         1490     1490           
  Misses          4        4           
Impacted Files Coverage Δ
src/lib/errors/CombinedError.ts 100.00% <100.00%> (ø)
src/lib/errors/CombinedPropertyError.ts 100.00% <100.00%> (ø)
src/lib/errors/ExpectedConstraintError.ts 100.00% <100.00%> (ø)
src/lib/errors/ExpectedValidationError.ts 100.00% <100.00%> (ø)
...lib/errors/MultiplePossibilitiesConstraintError.ts 100.00% <100.00%> (ø)
src/lib/errors/UnknownPropertyError.ts 100.00% <100.00%> (ø)
src/lib/errors/ValidationError.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23d15f...ecfd35a. Read the comment docs.

Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs updating too:

"node": ">=v15.0.0",

@vladfrangu vladfrangu requested a review from kyranet June 17, 2022 21:44
@favna favna changed the title chore: use es2020 instead of es2021 fix: compile for es2020 instead of es2021 Jun 19, 2022
@favna favna merged commit 051344d into main Jun 19, 2022
@favna favna deleted the chore/downlevel-shapeshift-to-es2020 branch June 19, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants