Filter out None results before sorting python version list #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue of trying to sort non-python results in the
find_all_python_versions
function.This was attempted in #87, but this is still an issue for me and a lot of other users.
For some reason, the
versions
list can contain non-existing entries. For instance on my machine it contains among others an entry of a version I uninstalled a long time ago:When
as_python.version_sort
of such an entry is accessed in order to sort the list, it panics becauseas_python
returnsNone
.It would probably be best to attack this issue at the source as well, but filtering out these kind of results at the location where they're accessed is a start.