Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(request-client): implemented verbose mode #824

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

YuryShkoda
Copy link
Member

Issue

This feature has been added to support sasjs/cli#1356.

Intent

  • Add a method that intercepts every HTTP response and logs its summary.
  • Add a method that disables HTTP response interception.

Implementation

  • Added enableVerboseMode method to RequestClient class.
  • Added disableVerboseMode method to RequestClient class.
  • Added defaultInterceptionCallBack method to RequestClient class.

Checks

No PR (that involves a non-trivial code change) should be merged, unless all items below are confirmed! If an urgent fix is needed - use a tar file.

  • All sasjs-cli unit tests are passing (npm test).
  • (CI Runs this) All sasjs-tests are passing. If you want to run it manually (instructions available here).
  • Data Controller builds and is functional on both SAS 9 and Viya

@sasjsbot sasjsbot requested a review from medjedovicm July 27, 2023 16:36
@github-actions
Copy link

github-actions bot commented Jul 27, 2023

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 63.54% 2072/3261
🔴 Branches 45.07% 754/1673
🔴 Functions 54.24% 307/566
🟡 Lines 73.01% 3462/4742

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🔴 src/SASjs.ts 30.03% 6.53% 10.42% 58.19%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from ccb8599

medjedovicm
medjedovicm previously approved these changes Jul 27, 2023
@YuryShkoda YuryShkoda merged commit f1e1b33 into master Jul 31, 2023
@YuryShkoda YuryShkoda deleted the startComputeJob-issue branch July 31, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants