Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with selecting area #680

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Fix issue with selecting area #680

merged 1 commit into from
Nov 6, 2023

Conversation

Christian24
Copy link
Contributor

Hello,

I noticed a little bug:

angular-seed-app/src/app/data/data.component.ts

Line 12 in 0dac83f

public selectedArea: any = null
sets selectedArea to null, yet the template

angular-seed-app/src/app/data/data.component.html

Line 6 in 0dac83f

<option *ngIf="selectedArea === undefined" [value]="undefined">
checks if selectedArea is undefined. Therefore I changed it in the component to undefined as well.

@allanbowe allanbowe requested a review from medjedovicm November 6, 2023 19:39
@allanbowe
Copy link
Member

allanbowe commented Nov 6, 2023 •
edited
Loading

thanks for the contribution! @all-contributors - please add @Christian24 for code

@allanbowe allanbowe merged commit ef78cd0 into sasjs:main Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medjedovicm medjedovicm Awaiting requested review from medjedovicm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Christian24 @allanbowe