Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bumping sasjs/core and sasjs/lint #1238

Merged
merged 3 commits into from
Aug 15, 2022
Merged

fix: bumping sasjs/core and sasjs/lint #1238

merged 3 commits into from
Aug 15, 2022

Conversation

allanbowe
Copy link
Member

@allanbowe allanbowe commented Aug 15, 2022

Issue

sasjs/lint#166

Intent

Bumping core (for more efficient JSON generation) and lint (for ignoring particular sas files)

Implementation

Bumped @sasjs/core and @sasjs/lint

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • JSDoc comments have been added or updated.
  • Reviewer is assigned.

@sasjsbot sasjsbot requested a review from medjedovicm August 15, 2022 17:52
sabhas
sabhas previously approved these changes Aug 15, 2022
@allanbowe
Copy link
Member Author

failing only on server tests, due to Viya being down

@allanbowe allanbowe merged commit da7b353 into main Aug 15, 2022
@allanbowe allanbowe deleted the bumpthings branch August 15, 2022 18:32
@sasjsbot
Copy link

🎉 This PR is included in version 3.18.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants