Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sasjs deploy should return error when deployment fails #1315

Merged
merged 1 commit into from
Feb 3, 2023
Merged

fix: sasjs deploy should return error when deployment fails #1315

merged 1 commit into from
Feb 3, 2023

Conversation

sabhas
Copy link
Member

@sabhas sabhas commented Feb 3, 2023

Issue

closes #1128

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • JSDoc comments have been added or updated.
  • Reviewer is assigned.

@sasjsbot sasjsbot requested a review from YuryShkoda February 3, 2023 14:17
@allanbowe allanbowe merged commit 946ab6a into main Feb 3, 2023
@allanbowe allanbowe deleted the issue-1128 branch February 3, 2023 14:58
@sasjsbot
Copy link

sasjsbot commented Feb 3, 2023

🎉 This PR is included in version 3.27.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanbowe allanbowe allanbowe approved these changes

@medjedovicm medjedovicm medjedovicm approved these changes

@YuryShkoda YuryShkoda Awaiting requested review from YuryShkoda

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sasjs deploy should return error (remove successful deploy note when there is an error)
4 participants
@sabhas @sasjsbot @allanbowe @medjedovicm