Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump sasjs utils #1321

Merged
merged 5 commits into from
Feb 22, 2023
Merged

fix: bump sasjs utils #1321

merged 5 commits into from
Feb 22, 2023

Conversation

sabhas
Copy link
Member

@sabhas sabhas commented Feb 20, 2023 •
edited
Loading

Issue

closes #1308

Intent

  • remove csv-stringify dependency from cli and use the createCsv in place of that.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • JSDoc comments have been added or updated.
  • Reviewer is assigned.

@sabhas sabhas changed the title fix: bump sasjs lint and sasjs utils fix: bump sasjs lint Feb 21, 2023
@allanbowe allanbowe merged commit ead7bd4 into main Feb 22, 2023
@allanbowe allanbowe deleted the issue-1308 branch February 22, 2023 00:14
@sasjsbot
Copy link

🎉 This PR is included in version 3.27.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sabhas sabhas changed the title fix: bump sasjs lint fix: bump sasjs utils Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanbowe allanbowe allanbowe approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Friendly message when webSourcePath is not defined
3 participants
@sabhas @sasjsbot @allanbowe