Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippets generation feature #1357

Merged
merged 20 commits into from
Aug 7, 2023
Merged

Snippets generation feature #1357

merged 20 commits into from
Aug 7, 2023

Conversation

YuryShkoda
Copy link
Member

@YuryShkoda YuryShkoda commented Jul 19, 2023

Intent

  • Implement sasjs command to generate VS Code snippets from SAS Macros.

Implementation

  • Added sasjs snippets command.
  • Covered sasjs snippets command with unit tests.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • Unit tests coverage has been increased and a new threshold is set.
  • All CI checks are green.
  • Development comments have been added or updated.
  • Development documentation coverage has been increased and a new threshold is set.
  • Reviewer is assigned.

Reviewer checks

  • Any new code is documented.

@sasjsbot sasjsbot requested a review from medjedovicm July 19, 2023 12:24
@github-actions
Copy link

github-actions bot commented Jul 19, 2023

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 73.49% 3290/4477
🟡 Branches 60.41% 1300/2152
🟡 Functions 73.57% 668/908
🟢 Lines 82.48% 8472/10272

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from b405852

@YuryShkoda YuryShkoda requested review from sabhas and removed request for medjedovicm July 19, 2023 12:38
@YuryShkoda YuryShkoda requested a review from allanbowe August 7, 2023 09:59
@YuryShkoda YuryShkoda requested a review from sabhas August 7, 2023 10:44
@YuryShkoda YuryShkoda merged commit 643fe8e into main Aug 7, 2023
@YuryShkoda YuryShkoda deleted the snippet branch August 7, 2023 11:25
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 4.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants