Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(verbose): added verbose mode and deprecated --returnStatusOnly #1361

Merged
merged 13 commits into from
Aug 3, 2023

Conversation

YuryShkoda
Copy link
Member

@YuryShkoda YuryShkoda commented Aug 2, 2023

Issue

Closes #1356

Intent

  • Deprecate --returnStatusOnly flag in sasjs job execute command.
  • Implement --verbose flag in sasjs job execute command.
  • Implement verbose mode that should be enabled iF VERBOSE entry is present in .env file.

Implementation

  • Changed sasjs job command.
  • Adjusted unit tests.
  • Changed getSASjs utility that should instantiate of SASjs class with verbose mode on/off.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • JSDoc comments have been added or updated.
  • Reviewer is assigned.

@sasjsbot sasjsbot requested a review from medjedovicm August 2, 2023 07:44
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 73.19% (+1.06% 🔼) 3233/4417
🟡 Branches 60.06% (+1.81% 🔼) 1278/2128
🟡 Functions 73.24% 654/893
🟢 Lines 82.3% 8368/10168

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🟢 src/utils/test.ts 84.66% (-1.14% 🔻) 68.12% 77.14% 91.12%
🟢 src/utils/saveLog.ts 100% 60% (-10.59% 🔻) 100% 100%
🟢 src/commands/compile/compileSingleFile.ts 95.83% (-2.08% 🔻) 84% (-4% 🔻) 100% 100%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 7452b4d

@YuryShkoda YuryShkoda merged commit 504cde5 into main Aug 3, 2023
@YuryShkoda YuryShkoda deleted the issue-1356 branch August 3, 2023 10:49
@sasjsbot
Copy link

sasjsbot commented Aug 3, 2023

🎉 This PR is included in version 4.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate returnStatusOnly and enable debugging
4 participants