Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): fixed verbose mode in getSASjs utility #1363

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Conversation

YuryShkoda
Copy link
Member

@YuryShkoda YuryShkoda commented Aug 4, 2023

Intent

  • Verbose mode should be enabled only by providing on(case insensitive) string to VERBOSE environment variable.

Implementation

  • Updated logic in getSASjs utility.
  • Updated unit tests.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • Development comments have been added or updated.
  • Development documentation coverage has been increased and new threshold is set.
  • Reviewer is assigned.

@sasjsbot sasjsbot requested a review from sabhas August 4, 2023 12:30
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 73.2% 3234/4418
🟡 Branches 60.09% 1280/2130
🟡 Functions 73.24% 654/893
🟢 Lines 82.3% 8368/10168

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🟢 src/utils/test.ts 84.66% (-1.14% 🔻) 68.12% 77.14% 91.12%
🟢 src/commands/compile/compileSingleFile.ts 95.83% (-2.08% 🔻) 84% (-4% 🔻) 100% 100%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 7ba8f15

@allanbowe allanbowe merged commit 90e1bc4 into main Aug 4, 2023
@allanbowe allanbowe deleted the verbose-fix branch August 4, 2023 19:05
@sasjsbot
Copy link

sasjsbot commented Aug 4, 2023

🎉 This PR is included in version 4.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants