feat(snippets): remove [in] and [out] from @params #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanbowe
reviewed
Aug 18, 2023
src/commands/snippets/snippets.ts
Outdated
| const briefRegExp = /^\s\s@brief\s/ | ||
| // to get lines that has @param keyword and optionally [in] or [out] string | ||
| // following it | ||
| const paramRegExp = /^\s\s@param\s(\[(in|out)\]\s)?/ |
There was a problem hiding this comment.
this should be case insensitive ideally
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from c2638cb |
medjedovicm
approved these changes
Aug 18, 2023
|
🎉 This PR is included in version 4.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
[in]and[out]@paramentries don't bring value, but just use limited space in VS Code snippet description.Intent
[in]and[out]@paramentries from snippet description.Implementation
src/commands/snippets/snippets.ts.Checks
npm run lint:fix).npm test).Reviewer checks