Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxLineLengthCards feature #47

Closed
allanbowe opened this issue May 8, 2021 · 5 comments · Fixed by #200
Closed

maxLineLengthCards feature #47

allanbowe opened this issue May 8, 2021 · 5 comments · Fixed by #200
Assignees
Labels

Comments

@allanbowe
Copy link
Member

allanbowe commented May 8, 2021

Datalines cannot be split over multiple lines, as each line represents an input data record. So it makes no sense to include them in the line length limit.

image

There are multiple 'flavours' of datalines. Each will begin / end with a line that begins with the markers below

section begin section end
datalines; ;
datalines4; ;;;;
cards; ;
cards4; ;;;;
parmcards; ;
parmcards4; ;;;;
@sasutils
Copy link

You probably do want to have a check for long data lines. First there are limits to what SAS will accept as a line length for a program file Second if your datalines are longer than your program lines then they belong in a separate text file.

@allanbowe
Copy link
Member Author

Hmm, you do have a point about the batch line length limit.

@allanbowe
Copy link
Member Author

Ok so the plan will be to have a maxLineLengthCards (to work only with datalines) that will default to max(maxLineLengthCards,maxLineLength)

@allanbowe allanbowe changed the title ignore max line length for datalines maxLineLengthCards feature Jan 5, 2023
@allanbowe allanbowe assigned sabhas and unassigned saadjutt01 Jan 5, 2023
@sasjsbot
Copy link

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sabhas
Copy link
Member

sabhas commented Jan 12, 2023

via Hubstaff
User: Sabir Hassan

Project: SASjs lint - https://app.hubstaff.com/projects/2310878
Date Range: 01/10/23 - 01/11/23
Work session total: 5:16:01
Billable: Yes

Grand total: 5:16:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants