Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new config maxDataLineLength #200

Merged
merged 3 commits into from
Jan 12, 2023
Merged

feat: add new config maxDataLineLength #200

merged 3 commits into from
Jan 12, 2023

Conversation

sabhas
Copy link
Member

@sabhas sabhas commented Jan 11, 2023 •
edited
Loading

Issue

closes #47

Intent

  • Datalines cannot be split over multiple lines, as each line represents an input data record. So it makes no sense to include them in the line length limit. Therefore, added a new config rule that deals with data lines

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • sasjslint-schema.json is updated with any new / changed functionality
  • JSDoc comments have been added or updated.
  • Reviewer is assigned.

@sasjsbot sasjsbot requested a review from saadjutt01 January 11, 2023 16:21
@allanbowe allanbowe merged commit ad59159 into main Jan 12, 2023
@allanbowe allanbowe deleted the issue-47 branch January 12, 2023 16:35
@sasjsbot
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medjedovicm medjedovicm medjedovicm approved these changes

@allanbowe allanbowe allanbowe approved these changes

@saadjutt01 saadjutt01 Awaiting requested review from saadjutt01

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

maxLineLengthCards feature
4 participants
@sabhas @sasjsbot @allanbowe @medjedovicm