Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: honour .gitignore when linting filesystems #167

Merged
merged 5 commits into from
Aug 15, 2022
Merged

feat: honour .gitignore when linting filesystems #167

merged 5 commits into from
Aug 15, 2022

Conversation

sabhas
Copy link
Member

@sabhas sabhas commented Aug 12, 2022 •
edited
Loading

Issue

closes #166

Intent

  • add a new attribute ignoreList to LintConfig
  • do not lint files that are specified in .gitignore

Implementation

  • added a new utility method isIgnored that specifies whether to ignore the linting of specified file/folder

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • sasjslint-schema.json is updated with any new / changed functionality
  • JSDoc comments have been added or updated.
  • Reviewer is assigned.

@sabhas sabhas changed the title Issue 166 feat: honour .gitignore when linting filesystems Aug 12, 2022
@sabhas sabhas requested a review from YuryShkoda August 12, 2022 11:01
YuryShkoda
YuryShkoda reviewed Aug 15, 2022
View reviewed changes
@allanbowe allanbowe merged commit 5ce33ab into main Aug 15, 2022
@allanbowe allanbowe deleted the issue-166 branch August 15, 2022 17:27
@sasjsbot
Copy link

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuryShkoda YuryShkoda YuryShkoda left review comments

@allanbowe allanbowe allanbowe approved these changes

@medjedovicm medjedovicm medjedovicm approved these changes

@krishna-acondy krishna-acondy Awaiting requested review from krishna-acondy

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

honour .gitignore when linting filesystems
5 participants
@sabhas @sasjsbot @allanbowe @medjedovicm @YuryShkoda