fix(hasMacroNameInMend): default sets to true #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
YuryShkoda
reviewed
Apr 15, 2021
src/lint/lintFile.spec.ts
Outdated
| @@ -8,7 +8,7 @@ describe('lintFile', () => { | |||
| path.join(__dirname, '..', 'Example File.sas') | |||
| ) | |||
|
|
|||
| expect(results.length).toEqual(8) | |||
| expect(results.length).toEqual(9) | |||
There was a problem hiding this comment.
we shouldn't use the exact numbers
YuryShkoda
reviewed
Apr 15, 2021
src/lint/lintFolder.spec.ts
Outdated
| @@ -10,7 +10,7 @@ describe('lintFolder', () => { | |||
| const diagnostics = results.get( | |||
| path.join(__dirname, '..', 'Example File.sas') | |||
| )! | |||
| expect(diagnostics.length).toEqual(8) | |||
| expect(diagnostics.length).toEqual(9) | |||
There was a problem hiding this comment.
we shouldn't use the exact numbers
YuryShkoda
reviewed
Apr 15, 2021
src/lint/lintProject.spec.ts
Outdated
| @@ -15,7 +15,7 @@ describe('lintProject', () => { | |||
| const diagnostics = results.get( | |||
| path.join(__dirname, '..', 'Example File.sas') | |||
| )! | |||
| expect(diagnostics.length).toEqual(8) | |||
| expect(diagnostics.length).toEqual(9) | |||
There was a problem hiding this comment.
we shouldn't use the exact numbers
YuryShkoda
reviewed
Apr 15, 2021
src/utils/getLintConfig.spec.ts
Outdated
| @@ -17,7 +17,7 @@ describe('getLintConfig', () => { | |||
| const config = await getLintConfig() | |||
|
|
|||
| expect(config).toBeInstanceOf(LintConfig) | |||
| expect(config.fileLintRules.length).toEqual(3) | |||
| expect(config.fileLintRules.length).toEqual(4) | |||
There was a problem hiding this comment.
we shouldn't use the exact numbers
|
We should probably replace assertions based on numbers with assertions based on |
krishna-acondy
approved these changes
Apr 16, 2021
|
🎉 This PR is included in version 1.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #26
Intent
Lint should has default value for
hasMacroNameInMendto betrueImplementation
getLintConfig.tsand.sasjslintto have true value forhasMacroNameInMendChecks
npm run lint:fix).npm test).