Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue53 #54

Merged
merged 3 commits into from
May 20, 2021
Merged

Issue53 #54

merged 3 commits into from
May 20, 2021

Conversation

saadjutt01
Copy link
Member

@saadjutt01 saadjutt01 commented May 20, 2021

Issue

Closes #53

Intent

Add new rule for strictly implementing macro definition syntax

Implementation

Add new file and test for strictMacroDefinition

  • strictMacroDefinition.ts
  • strictMacroDefinition.spec.ts

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • sasjslint-schema.json is updated with any new / changed functionality
  • JSDoc comments have been added or updated.
  • Reviewer is assigned.

@ghost ghost requested a review from medjedovicm May 20, 2021 14:15
@krishna-acondy krishna-acondy merged commit 482ecec into main May 20, 2021
@krishna-acondy krishna-acondy deleted the issue53 branch May 20, 2021 15:35
@ghost
Copy link

ghost commented May 20, 2021

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macroNameinMend option incorrectly adds macro system option to the %mend statement
2 participants