Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add utils for sasjs fs command #208

Merged
merged 19 commits into from
Oct 26, 2022
Merged

feat: add utils for sasjs fs command #208

merged 19 commits into from
Oct 26, 2022

Conversation

sabhas
Copy link
Member

@sabhas sabhas commented Oct 9, 2022 •
edited
Loading

Issue

closes #203

Intent

added the following utilities

  • generateCompileProgram
  • getHash
  • compareHash
  • generateProgramToGetRemoteHash
  • findResourcesNotPresentLocally

Checks

  • Code is formatted correctly (npm run lint:fix).
  • All unit tests are passing (npm test).
  • All sasjs-cli unit tests are passing (npm test).
  • Reviewer is assigned.

sabhas added 5 commits October 9, 2022 13:17
@sabhas
chore: add function header
9913743
@sabhas
fix: if a file is empty, ignore hash
22c3f37
@sabhas
chore: bump sasjs core version
4bb6e00
@sabhas
chore: move utils specs to specs folder
4172751
@sabhas
chore: move hash utils to fs/hash.ts file
4f67060 
update the hashing function to return result in tree form

add the compareHash function to return the difference of localHash and remote hash
@sabhas sabhas marked this pull request as draft October 19, 2022 19:08
@sabhas sabhas marked this pull request as ready for review October 25, 2022 09:20
@sabhas sabhas changed the title feat: Create a utility that hashes every file/folder in a directory feat: add utils for sasjs fs command Oct 25, 2022
@allanbowe allanbowe merged commit 1b632d4 into main Oct 26, 2022
@allanbowe allanbowe deleted the issue-203 branch October 26, 2022 10:12
@sasjsbot
Copy link

🎉 This PR is included in version 2.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanbowe allanbowe allanbowe left review comments

@VladislavParhomchik VladislavParhomchik Awaiting requested review from VladislavParhomchik

@YuryShkoda YuryShkoda Awaiting requested review from YuryShkoda

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a utility that hashes every file in a directory
3 participants
@sabhas @sasjsbot @allanbowe