Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid the /-as-division warning when running the dart_api tests #1467

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

stof
Copy link
Contributor

@stof stof commented Sep 5, 2021

Without this, the test output is full of deprecation warnings looking like that:

00:04 +314: test/dart_api/value/number_test.dart: an integer with numerator and denominator units doesn't equal a number with different units
DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(123px, 5ms)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
3 │     a {b: foo((123px / 5ms))}
  │                ^^^^^^^^^^^
  ╵
    - 3:16  root stylesheet

@jathak jathak merged commit 8012e0e into sass:main Sep 7, 2021
@stof stof deleted the avoid_warning branch September 8, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants