Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable useDefineForClassFields and fix affected TS files. #2447

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

Goodwine
Copy link
Member

Fixes #2419

Turning off this TS compiler option is deprecated, and it will be removed "soon". It's annoying.. but oh well.

@Goodwine Goodwine requested a review from nex3 November 28, 2024 01:09
Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint error, then LGTM.

Fixes #2419

Turning off this TS compiler option is deprecated, and it will be removed "soon". It's annoying.. but oh well.
@Goodwine Goodwine force-pushed the fix-useDefineForClassFields branch from 3216a74 to 9a1dce7 Compare December 5, 2024 03:49
@Goodwine Goodwine merged commit a74f9c3 into main Dec 5, 2024
39 checks passed
@Goodwine Goodwine deleted the fix-useDefineForClassFields branch December 5, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the tsconfig option useDefineForClassFields and fix relevant TS files
2 participants