Automate benchmarking and update benchmarks #356
Conversation
| await runAsync("git", | ||
| arguments: ["fetch", "origin"], workingDirectory: path); | ||
| await runAsync("git", | ||
| arguments: ["reset", "--hard", "origin/master"], |
There was a problem hiding this comment.
This can be a bit destructive on your local changes, if you ran it by accident. Not only to the working tree but also to the current branch pointer. I wonder if it'd be worth a git checkout origin/master just to be safe, so it'd error out if you had local changes.
Since it's only used for other sass impl repos it's probably pretty safe even so, but just wondering if the extra level of reset --hard is necessary.
There was a problem hiding this comment.
checkout doesn't update the local master branch's pointer, which I worry could hypothetically mess up some infrastructure. These repositories are all in the build/ directory anyway, which is generally expected to be destructively modified by grinder tasks, so I don't feel too bad about doing that here as well.
Closes #293