[Color 4] Update behavior to match latest specs #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goodwine
approved these changes
Apr 1, 2024
| const hue = normalizeHue(options.hue ?? NaN); | ||
| const saturation = options.saturation ?? NaN; | ||
| let lightness = options.lightness ?? NaN; | ||
| lightness = assertClamped(lightness, 0, 100, 'lightness'); |
There was a problem hiding this comment.
I see that the JS API says that there will no longer be errors thrown out when the lightness is out of the accepted range. But I'm slightly confused what's supposed to happen in that case. Is the value just passed through and the client/browser will handle such case?
There was a problem hiding this comment.
That's right. Per spec, it will ultimately be gamut-mapped into the display range of the view screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass#3823
See sass/dart-sass#2125
See sass/sass-spec#1966