Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null values in lists are not removed when interpolated in a string #1376

Closed
natecavanaugh opened this issue Jul 23, 2015 · 3 comments
Closed

Comments

@natecavanaugh
Copy link

The bug happens in libsass 3.2.5.
SCSS:

.div{
  $foo: 1, null, 2, null, 3;

  content: "#{$foo}";
}

Ruby Sass output:

.div {
  content: "1, 2, 3";
}

libsass output:

.div {
  content: "1, , 2, , 3";
}

I looked through the existing issues, and saw a few issues/fixes around lists of strings being interpolated improperly, but not sure if they also happened to fix this.
Thought I'd submit this, just in case it hadn't been caught :)

@mgreter
Copy link
Contributor

mgreter commented Jul 26, 2015

This seems just another specific detail we haven't caugth yet!

@xzyfer
Copy link
Contributor

xzyfer commented Jul 27, 2015

Fixed via #1389

xzyfer added a commit to xzyfer/sass-spec that referenced this issue Jul 27, 2015
@xzyfer xzyfer closed this as completed Jul 27, 2015
@natecavanaugh
Copy link
Author

Awesome, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants