3.4 support blockers!

[HamptonMakes]

Hey yo! Here is a mega ticket. I just went through all the specs over at sass-spec and made a new branch called "threefour" that is 100% s3.4 compatible in all tests. This is basically the primary hitlist for 3.2 development.

Here are the things I noticed breaking, and the tests that cover them.

• global! variable support
  • spec/basic/30_if_in_function
  • spec/scss/each-in-function
• fractions into decimals
  • spec/libsass-todo-tests/libsass/div
  • spec/libsass-todo-tests/libsass/delayed (*white-space diff)
• when we run into utf-8 characters, we throw in the charset
  • spec/libsass-todo-tests/charset
• handling of at-rules / directives
  • spec/libsass/047_test_unknown_directive_bubbling
  • spec/basic/38_expressions_in_at_directives (* selector order diff)
• @at-root support
  • spec/libsass/at-root/135_test_simple_at_root
  • spec/libsass/at-root/136_test_at_root_with_selector
  • spec/libsass/at-root/137_test_at_root_in_mixin
  • spec/libsass/at-root/139_test_at_root_in_bubbled_media
  • spec/libsass/at-root/142_test_multi_level_at_root_with_parent_ref
• hex math being a + [test_node_factory.cpp] Remove unused unordered_map include. #123 being #a123 instead of #a112233
  • spec/basic/16_hex_arithmetic
• weird issue with unquote(0xf00)
  • spec/libsass-todo-tests/libsass/colors
• selector ordering with @extends
  • spec/extend-tests/180_test_basic_extend_loop (* selector order diff)
• when you do 0.00000001 * -1 it should be 0.0 not 0
  • negative_numbers
• ignore attempts at escaping in strings. Aka "\t" should become "t" or "\n" to "n" instead of ""
  • spec/basic/25_basic_string_interpolation
• allow interpolation outside of quotes
  • spec/libsass-todo-tests/libsass/interpolated-urls

[xzyfer]

IMHO it's work creating issues for each of these and assigning them to a 3.4 milestone as per our roadmap. As is stands this issue doesn't feel actionable or approachable.

Thoughts?

[xzyfer]

Welcome back @hcatlin! Thoughts on my previous comment?

[mgreter]

The "weird issue with unquote(0xf00)" seems to have been fixed in ruby sass!

[xzyfer]

I've created #772 which I'll ship in 3.1.next.

It addresses spec/libsass-todo-tests/libsass/div.

[xzyfer]

@hcatlin I'd say it's work updating all todo specs on master so we don't end up patching against 3.3 functionality. I don't see any harm if they're already being skipped.

[HamptonMakes]

Sorry for not breaking this up. I'm a lazy, lazy developer. I'm updating the specs to match 3.4.9

[alanhogan]

Is this still accurate? There is only one blocker from 3.4 compatibility?

[xzyfer]

This is correct as of the current master with regards to major language features. If you want a more specific list of issues look at the github issues.

[xzyfer]

All of the supplied specs are passing as of current master. All outstanding failing specs have been converted to issues. There is now a Bug - Confirmed issue for ever known LibSass bug.

https://github.com/sass/libsass/issues?q=is%3Aopen+is%3Aissue+label%3A%22Bug+-+Confirmed%22