keywords($args) does not default to empty map

[jakob-e]

When passing non-keyword-arguments keyword function trows
Error: basic_string::basic_string rather than creating an empty map

@mixin mixin($arglist...){
    $map: keywords($arglist);
}

.test {
    // As expected 
    // $map: (width: 200px, height: 100px);  
   @include mixin( $width: 200px, $height: 100px);

   // As expected 
   // $map: ();
   @include mixin( );

    // Throws: "Error: basic_string::basic_string"
    // Expected $map: ();  
   @include mixin( not-keyword-format );
}

[xzyfer]

Could you please add a spec in https://github.com/sass/sass-spec ?

Here's an example of a good spec PR for reference https://github.com/sass/sass-spec/pull/89/files

[jakob-e]

👍... I think I could have done it in just one pull (tsk-tsk newbies ;-)

sass/sass-spec#147
sass/sass-spec#148

Note I've added it to the maps folder to keep things together
spec/maps/keywords/

[xzyfer]

Thanks @jakob-e . I've left some feedback on those PR. Ideally one PR would be best, as well as sticking the existing convention of putting specs for issues in libsass-todo-issues. It's part of the Libsass development workflows and makes our lives easier when fixing these issues.

[jakob-e]

Thanks @xzyfer I've moved the files to issue_672 in libsass-todo-issues and made a new PR
I hope I did close the old ones correctly – sorry in advance – Thanks for teaching me 👍
sass/sass-spec#149

[xzyfer]

Looks good! Thanks for your help
On 24 Nov 2014 19:37, "jakob-e" [email protected] wrote:

Thanks @xzyfer https://github.com/xzyfer I've moved the files to
issue_672 in libsass-todo-issues and made a new PR
I hope I did close the old ones correctly – sorry in advance – Thanks for
teaching me [image: 👍]

sass/sass-spec#149 sass/sass-spec#149

—
Reply to this email directly or view it on GitHub
#672 (comment).

[xzyfer]

Spec added in sass/sass-spec@a164ef0