Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with not? #920

Closed
mdix opened this issue Mar 5, 2015 · 5 comments
Closed

Problems with not? #920

mdix opened this issue Mar 5, 2015 · 5 comments
Assignees
Milestone

Comments

@mdix
Copy link

mdix commented Mar 5, 2015

Hi,

I'm having a strange issue. Please look at this code and the output: https://gist.github.com/mdix/5ac29a781053c0679d60

You might also test it on sassmeister: http://sassmeister.com/gist/5ac29a781053c0679d60

Now, the problem is, that this always results in the warning "WARNING: No z-index found in $z-layers map for shop-header-dropdown. Property omitted." when compiling it with 'grunt-sass' (which uses node-sass 1.2.3). So, it seems that it runs into the wrong branch (just as if not is ignored).

Can you please check and report back to me on this issue?

Thanks and kind regards
Marc

@xzyfer
Copy link
Contributor

xzyfer commented Mar 5, 2015

Thanks for the report @mdix. This has been fixed and will be 3.2.

@xzyfer xzyfer closed this as completed Mar 5, 2015
@mdix
Copy link
Author

mdix commented Mar 5, 2015

Any workarounds for the time being?

@xzyfer
Copy link
Contributor

xzyfer commented Mar 5, 2015

I've looked further into it. This specific problem has been fixed in 3.1.0. If you update node-sass to 2.0.1 this will be fixed. Alternatively you could try inverting the @if

@function z($layer) {
  @if map-has-key($z-layers, $layer) {
    @return map-get($z-layers, $layer);
  }

  @warn "No z-index found in $z-layers map for `#{$layer}`. Property omitted.";
  @return null;
}

@mdix
Copy link
Author

mdix commented Mar 5, 2015

Darn... of course it can be inverted. Thanks for your help!

mdix pushed a commit to AOEpeople/Aoe_SCSS_helpers that referenced this issue Mar 5, 2015
@xzyfer xzyfer added this to the 3.2 milestone Mar 11, 2015
@xzyfer xzyfer self-assigned this Mar 11, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Mar 11, 2015

Duplicate of #873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants