Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Travis OS X Support #1024

Merged
merged 1 commit into from
Apr 1, 2015
Merged

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Apr 1, 2015

Basically just uncommented the prepared osx support in .travis.yml and it worked!
Additionally removed gcc compiler target for osx since it is only an alias to clang!

@mgreter mgreter force-pushed the test/travis-osx-support branch from d6b5422 to 2062a1e Compare April 1, 2015 18:54
@mgreter
Copy link
Contributor Author

mgreter commented Apr 1, 2015

Actually I'm tempted to just merge this now, since it compiles correctly on Mac OS-X with native Makefiles and Autotools build with very minimal changes (2 chars removed) 😎 Actually we should probably try to disable gcc build, since gcc seems to be just an alias for clang on OS-X (which makes sense).

//CC @xzyfer, @hcatlin

@mgreter mgreter changed the title [DNM] Test Travis OS X support Enable Travis OS X Support Apr 1, 2015
@mgreter mgreter force-pushed the test/travis-osx-support branch from 2062a1e to c9b8ee5 Compare April 1, 2015 20:01
@coveralls
Copy link

Coverage Status

Coverage increased (+0.23%) to 80.31% when pulling c9b8ee5 on mgreter:test/travis-osx-support into d215db5 on sass:master.

@mgreter mgreter self-assigned this Apr 1, 2015
@mgreter mgreter added this to the 3.2 milestone Apr 1, 2015
@mgreter mgreter added the Build label Apr 1, 2015
mgreter added a commit that referenced this pull request Apr 1, 2015
@mgreter mgreter merged commit fd7f20f into sass:master Apr 1, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Apr 1, 2015

Nice!

@xzyfer
Copy link
Contributor

xzyfer commented Apr 1, 2015

Actually we should probably try to disable gcc build, since gcc seems to be just an alias for clang on OS-X (which makes sense).

Agreed.

@mgreter mgreter deleted the test/travis-osx-support branch April 6, 2015 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants