Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix str-slice function to work with utf8 strings #1047

Merged
merged 1 commit into from
Apr 30, 2015
Merged

Fix str-slice function to work with utf8 strings #1047

merged 1 commit into from
Apr 30, 2015

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Apr 5, 2015

No description provided.

@mgreter mgreter self-assigned this Apr 5, 2015
@mgreter mgreter added this to the 3.2.1 milestone Apr 5, 2015
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 80.64% when pulling cbbdc06 on mgreter:bugfix/str-slice-function into f82a41b on sass:master.

QuLogic
QuLogic reviewed Apr 5, 2015
View reviewed changes
functions.cpp
Number* n = ARG("$start-at", Number);
Number* m = ARG("$end-at", Number);
double start_at = ARG("$start-at", Number)->value();
double end_at = ARG("$end-at", Number)->value();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it really need to be double, and not something integral?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it will be used as a size_t anyway. But the value passed by value() is a double, so I thought this makes it more clear that there is a conversion (and we may have to add correct behavior according to ruby sass what happens if non integers are passed in).

@mgreter mgreter force-pushed the bugfix/str-slice-function branch 2 times, most recently from 432d635 to e89d616 Compare April 6, 2015 18:03
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 80.64% when pulling e89d616 on mgreter:bugfix/str-slice-function into f82a41b on sass:master.

@mgreter mgreter mentioned this pull request Apr 30, 2015
Closed
9 tasks
@xzyfer xzyfer modified the milestones: 3.2.1, 3.2.2 Apr 30, 2015
@mgreter mgreter force-pushed the bugfix/str-slice-function branch from e89d616 to 3467e60 Compare April 30, 2015 01:28
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 80.29% when pulling 3467e60 on mgreter:bugfix/str-slice-function into 9ad775f on sass:master.

mgreter added a commit to mgreter/sass-spec that referenced this pull request Apr 30, 2015
@mgreter
Activate passing spec tests in preparation for 3.2.1
9674afd 
- sass/libsass#1055
- sass/libsass#1049
- sass/libsass#1047
- sass/libsass#1138
@mgreter mgreter mentioned this pull request Apr 30, 2015
Merged
xzyfer added a commit that referenced this pull request Apr 30, 2015
@xzyfer
Merge pull request #1047 from mgreter/bugfix/str-slice-function
fc4b39e 
Fix `str-slice` function to work with utf8 strings
@xzyfer xzyfer merged commit fc4b39e into sass:master Apr 30, 2015
@mgreter mgreter deleted the bugfix/str-slice-function branch July 28, 2015 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mgreter mgreter

Labels
Dev - PR Ready
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@mgreter @coveralls @QuLogic @xzyfer