VS Exception handling only in C++ code #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (arr == 0) throw(std::bad_alloc()); | ||
| char** arr = (char**) calloc(num + 1, sizeof(char*)); | ||
| if (arr == 0) | ||
| return; |
There was a problem hiding this comment.
Maybe set *array to NULL as an equivalent to the exception?
There was a problem hiding this comment.
Sure, my mistake. Even more, let's make it return the (char **) pointer for easier error checking.
saper
referenced
this pull request
Sep 3, 2015
* See http://stackoverflow.com/a/13841791/863980. * Also fixes a case where non-throw exception was throwing in sass_context.cpp.
|
Can you resolve the conflicts? Otherwise LGTM! |
|
Solved in a private branch, will push in the morning CEST |
xzyfer
added a commit
that referenced
this pull request
Sep 6, 2015
VS Exception handling only in C++ code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch exceptions only in C++ code,
extern "C" functions should (ideally) be exception-free.
While here, move functions shared between
sass_interface.cppandsass_context.cppintoutil.cppFixes: #1508