Pass "keep comments" flag to improve error message line numbers

[anlutro]

Currently, if I have a Sass file with invalid syntax and comments, the line numbers are off because the sass2scss process doesn't preserve comments. This is fixed by changing the options bit int passed to the sass2scss function.

Hopefully I got the bit flag right, I don't work with this sort of thing on a regular basis!

Before:

$ cat -n ../test.sass 
     1  // some comment
     2  ;
$ ./sassc/bin/sassc ../test.sass 
/home/andreas/dev/test.sass:1: invalid top-level expression

After:

$ ./sassc/bin/sassc ../test.sass 
/home/andreas/dev/test.sass:2: invalid top-level expression

[mgreter]

It actually should be a | instead of a +

SASS2SCSS_PRETTIFY_1 | SASS2SCSS_KEEP_COMMENT

Other than that I guess we would merge it in!

[anlutro]

Fixed, thanks.

[coveralls]

Coverage remained the same at 76.09% when pulling 917d509 on alprs:fix_comments-stacktrace into 4d5ea59 on sass:master.

[coveralls]

Coverage remained the same at 76.43% when pulling 7ce1e5c on alprs:fix_comments-stacktrace into 1f40bf4 on sass:master.

[anlutro]

Anything blocking this?

[xzyfer]

Thanks for you work!

This is @mgreter's area and he is currently busy with #899

We'll make sure this makes it into the next release.

[anlutro]

Ah, I see. I've been compiling all the time so releases aren't a huge deal
to me personally - I'll just keep rebasing against master until then, I was
just curious.

On Sun, 22 Feb 2015 00:56 Michael Mifsud [email protected] wrote:

Thanks for you work!

This is @mgreter https://github.com/mgreter's area and he is currently
busy with #899 #899

We'll make sure this makes it into the next release.

—
Reply to this email directly or view it on GitHub
#866 (comment).

[am11]

👍