Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @error fatal. Resolves #967. #971

Merged
merged 1 commit into from
Mar 19, 2015
Merged

Make @error fatal. Resolves #967. #971

merged 1 commit into from
Mar 19, 2015

Conversation

asottile
Copy link
Member

Manual testing as requested!

$ ./bin/sassc test.scss 
Error: hai
        on line 1 of test.scss
>> a { @error 'hai'; }
   ----^
$ echo $?
1

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 80.17% when pulling 05dc97d on asottile:error_fatal into bb10765 on sass:master.

@xzyfer
Copy link
Contributor

xzyfer commented Mar 19, 2015

Am I correct in remembering that error give us the backtrace trace that you've removed?

@asottile
Copy link
Member Author

ah yeah I've made an unused variable. I'll remove that. You can see the sample output in the description of the PR

@asottile
Copy link
Member Author

fixed!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 80.19% when pulling 21cc378 on asottile:error_fatal into bb10765 on sass:master.

@xzyfer
Copy link
Contributor

xzyfer commented Mar 19, 2015

Yeah cool just wanted to make sure backtraces were maintained. It's hard to tell from the example since there's not nesting to unwind.

I have confirmed this is the case - https://github.com/sass/libsass/blob/master/error_handling.cpp#L14-L21

Great work! Thanks!

xzyfer added a commit that referenced this pull request Mar 19, 2015
@xzyfer xzyfer merged commit 3681c48 into sass:master Mar 19, 2015
@xzyfer xzyfer added this to the 3.2 milestone Mar 19, 2015
@asottile asottile deleted the error_fatal branch March 19, 2015 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants