Implement !global assignments
#986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreter
force-pushed
the
feature/global-assignments
branch
from
5e0df58 to
2e08714
Compare
mgreter
force-pushed
the
feature/global-assignments
branch
4 times, most recently
from
b21545f to
a03658b
Compare
mgreter
changed the title
!global assignments!global assignments
|
@xzyfer maybe you want to review? IMO it's ready to be merged! |
mgreter
force-pushed
the
feature/global-assignments
branch
from
a03658b to
d8380df
Compare
mgreter
force-pushed
the
feature/global-assignments
branch
from
d8380df to
b221b40
Compare
mgreter
added a commit
that referenced
this pull request
Mar 27, 2015
Implement `!global` assignments
|
Sorry I've been offline running a conference. I'll catch up today. |
| @@ -145,7 +145,9 @@ namespace Sass { | |||
| static mt19937 rand(static_cast<unsigned int>(GetSeed())); | |||
|
|
|||
| // features | |||
| static set<string> features; | |||
| static set<string> features { | |||
| "global-variable-shadowing" | |||
There was a problem hiding this comment.
We should remember to mention this in the changelog.
|
LGTM, nice one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented correct
!globaland!defaulthandling. Was actually not that hard once I "understood" how it all ought to work, but@forand@eachthrew me off a bit, since they don't seem to be "real" blocks (they don't seem to have their own env scope). Added a few additional spec tests which should cover some of the more advanced use cases (which haven't been covered yet). sass/sass-spec#282Oh and btw. this fixes #613