This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Add Node.js 4 to AppVeyor #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We expect this to fail without #1128 |
xzyfer
force-pushed
the
feat/appveyor-4
branch
from
6b7aade to
985be93
Compare
|
This suggest you're adding io.js 4 because of the comment above. |
xzyfer
force-pushed
the
feat/appveyor-4
branch
from
985be93 to
05b7c9c
Compare
|
node -> node.js to be consistent with the first comment? Sorry for nitpicking. This is not terribly important. :D |
|
@mzgol I recall there is was meant to a distinction between Node, io.js and Node.js because of trademark issues. Can't remember the specifics. I'll look into it. |
|
I meant that the first comment says "node.js" and the third just "node". The official name is Node.js in both cases. |
This was referenced Oct 16, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Node.js 4 support to AppVeyor matching the Travis config (#1130)