Feature: Custom Functions #783
Conversation
am11
force-pushed
the
matryo-branch
branch
4 times, most recently
from
0a502bf to
5211c5d
Compare
am11
force-pushed
the
matryo-branch
branch
7 times, most recently
from
3889737 to
4d0c8ee
Compare
|
This is a historical moment!
|
| bridge.success(data); | ||
| } | ||
|
|
||
| var result = callback.apply(this, args.concat(done)); |
There was a problem hiding this comment.
callback.apply(options.context, args.concat(done)) for consistency with importers?
There was a problem hiding this comment.
No worries. Let me know how (if) I can help. :)
There was a problem hiding this comment.
@Jakobo Yes this makes complete sense. Ultimately I can see that the context could be used to call built-in sass functions, or functions defined through the sass files.
There was a problem hiding this comment.
Totally. We've already seen the context object be useful in import-once importer development, and I have no doubt that image manipulation custom functions will memoize using the context for performance. :)
There was a problem hiding this comment.
@Jakobo, wow image manipulation, like generating and mapping sprites? One day I will learn all the powers and mysteries behind this.conext, but I don't get time to actually use node-sass like others do! 😸
There was a problem hiding this comment.
@Jakobo, now that #644 is merged, would you like to send a PR for this.context and the tests which goes with it? (-8
You may want to play with this cool new feature as well. 😉
Supersedes #644.