Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

CLI: Adds support for Custom Functions #815

Merged
merged 1 commit into from
Mar 28, 2015
Merged

CLI: Adds support for Custom Functions #815

merged 1 commit into from
Mar 28, 2015

Conversation

am11
Copy link
Contributor

@am11 am11 commented Mar 28, 2015

  • Adds related tests and fixtures.

Issue URL: #784.

@am11
CLI: Adds support for Custom Functions.
d91917a 
* Adds related tests and fixtures.

Issue URL: sass#784.
PR URL: sass#815.
am11
am11 reviewed Mar 28, 2015
View reviewed changes
bin/node-sass
@@ -227,6 +230,14 @@ function run(options, emitter) {
}
}

if (options.functions) {
if ((path.resolve(options.functions) === path.normalize(options.functions).replace(/(.+)([\/|\\])$/, '$1'))) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed ugly, but without path resolution, user would need to specify ./ (or .\ in Windows) before the relative paths, which IMO is less flexible.

am11 added a commit that referenced this pull request Mar 28, 2015
@am11
Merge pull request #815 from am11/master
dc237d9 
CLI: Adds support for Custom Functions
@am11 am11 merged commit dc237d9 into sass:master Mar 28, 2015
@am11 am11 mentioned this pull request Mar 28, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature - Implementation Module - CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@am11