This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Adding a test for importer callback order #998
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to add a test case for sass/libsass#1262 and this test is currently failing. I have chatted with @xzyfer and he thinks it's a bug.
Besides the main point (the callback order is not DFS), I also found that the importer won't callback for the nested nodes.
This test add
index.scss
and tree is as follows:Actually,
node-sass
calls nodes in the order of[a, common, b, common, a1, vars, struct, b1]
instead of[a, common, vars, struct, a1, common, vars, struct, b, b1]
Not only the order is wrong, but alsovars
andstruct
didn't get called twice.