Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for issue 702 #161

Merged
merged 1 commit into from
Dec 10, 2014
Merged

Add specs for issue 702 #161

merged 1 commit into from
Dec 10, 2014

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Dec 9, 2014

This PR adds and activates specs for feature-exists (sass/libsass#702) in preparation for sass/libsass#709.

@xzyfer xzyfer mentioned this pull request Dec 9, 2014
Merged
xzyfer added a commit that referenced this pull request Dec 10, 2014
@xzyfer
Merge pull request #161 from xzyfer/feat/issue-702
692dc07 
Add specs for issue 702
@xzyfer xzyfer merged commit 692dc07 into sass:master Dec 10, 2014
@KittyGiraudel
Copy link
Contributor

I think this spec is wrong. It is probably not a good idea to expect a false value from those function calls.

If LibSass ends up supporting feature-exists("at-error") for instance, this test will break. Also, this makes the spec unusable for Sass 3.4 (which we try to do at sass-compatibility/sass-compatibility.github.io).

@xzyfer xzyfer mentioned this pull request Dec 11, 2014
Merged
@xzyfer
Copy link
Contributor Author

xzyfer commented Dec 11, 2014

Agreed. Spec updated in #172.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xzyfer @KittyGiraudel