Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some specs for implicit dependencies #1666

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Add some specs for implicit dependencies #1666

merged 2 commits into from
Jun 8, 2021

Conversation

jathak
Copy link
Member

@jathak jathak commented Jun 7, 2021

[skip dart-sass]

@jathak jathak requested a review from nex3 June 7, 2021 23:22
@jathak jathak mentioned this pull request Jun 7, 2021
Merged
nex3
nex3 requested changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there are holes in the matrix of tested cases: what about use_in_first? forward_second? The combination of the two?

@jathak
Copy link
Member Author

jathak commented Jun 8, 2021

Added more tests for the full combination of first being forwarded or not, and whether there's a use rule in first and/or second. Forwarding second would mean it's now in its own module, so it would no longer have the implicit dependency.

@jathak jathak requested a review from nex3 June 8, 2021 20:01
@jathak jathak merged commit 287d2b2 into master Jun 8, 2021
@jathak jathak deleted the implicit-dep-fix branch June 8, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nex3 nex3 nex3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jathak @nex3